ci: self-contained build + sign for challenger-go (RFC-044.4 WS3a follow-up)#26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces
docker.yml's delegation to the privatedocker-build-and-publish.yamlreusable with an in-repo build (faithful port for
challenger-go) plus this repo'sembedded signer.
Why
This repo is public; it cannot call the private
actions-workflowsreusables, so theold
docker.yml(which delegated the entire build+publish+sign todocker-build-and-publish.yaml@main) was broken on public and could not run at all.The new workflow:
ghcr.io/chronicleprotocol/challenger-goinline (same actions, SHApins, build-args
APP_NAME/APP_VERSION, platforms, and metadata tagging as theprivate reusable used for this app), then
chronicleprotocol/challenger/.github/workflows/sign-image.yaml@main. The@mainpin makes the keyless SANsign-image.yaml@refs/heads/main, matching theKyverno
verify-chronicle-release-imagesenforce identity.No behavior change to the produced image (same Dockerfile, args, platforms); only the
build/sign now run in-repo instead of via the unreachable private reusable.
Test plan
workflow_dispatchwith aversion: confirmchallenger-go:<version>+:sha-...are built/pushed and signed.
cosign verify ghcr.io/chronicleprotocol/challenger-go@<digest>against.../challenger/.github/workflows/sign-image.yaml@refs/heads/mainpasses.