Open
Conversation
Author
|
@Kehrlann ping |
Contributor
|
(I'm currently off sick, will run the integration test next week.) |
Kehrlann
requested changes
Apr 21, 2026
| import org.cloudfoundry.operations.applications.TaskState; | ||
| import org.cloudfoundry.operations.applications.TerminateApplicationTaskRequest; | ||
| import org.cloudfoundry.operations.applications.UnsetEnvironmentVariableApplicationRequest; | ||
| import org.cloudfoundry.operations.applications.*; |
Contributor
There was a problem hiding this comment.
The imports are broken, please revert to explicit imports and just add what you need.
Comment on lines
+568
to
+573
| this.cloudFoundryOperations | ||
| .applications() | ||
| .getApplicationManifest( | ||
| GetApplicationManifestRequest.builder() | ||
| .name(applicationName) | ||
| .build())) |
Contributor
There was a problem hiding this comment.
This does not return ApplicationFeatures (it's null), because this getApplicationManifest is a synthetic manifest build by CFJC itself (source)
You want to either:
- Update operations to get the app features and put them in the manifest
- Update the test to use the v3 features API to list features and check the result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1263