fix(test): image ordering test update

[tsim-sap]

Description

   - Updated seed10Entries to swap component IDs during seeding, ensuring that ID order is different from vulnerability severity order.
   - Added a new test case to verify that querying images without a service filter does not result in an error.
   - Verified that existing tests now correctly fail if the sorting logic is removed.

What type of PR is this?

• ✅ Test

Related Tickets & Documents

• Closes test(image): update image ordering test #1207

Remove if not applicable

Added tests?

• 👍 yes

Added to documentation?

• 🙅 no documentation needed

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[michalkrzyz]

Looks good!

[Copilot]

Pull request overview

This PR updates the image ordering E2E coverage to better lock in the expected “sort by vulnerability counts, then repository” behavior, and adjusts the GraphQL image resolver so image queries don’t error when no service filter is provided.

Changes:

• Adjusted seed10Entries to remap component IDs during seeding so ordering tests fail if severity-based sorting is removed.
• Added an E2E test case ensuring the images query succeeds even with an empty filter (no service filter).
• Updated ImageBaseResolver ordering logic to only apply severity-count ordering when a service filter is present (avoids SQL errors due to missing service-scoped count joins).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
internal/e2e/image_query_test.go	Adds an E2E test for “no service filter” and tweaks seeding to strengthen ordering assertions.
internal/api/graphql/graph/baseResolver/image.go	Makes default ordering conditional on service being provided to prevent errors in the unscoped case.

Comments suppressed due to low confidence (1)

internal/api/graphql/graph/baseResolver/image.go:59

• Ordering only by repository name can be non-deterministic when multiple components share the same repository, which can break cursor-based pagination. Other resolvers add a stable ID as a final tie-breaker (e.g., ServiceBaseResolver appends ServiceId; ComponentVersionBaseResolver appends ComponentVersionId). Add ComponentId as a final ordering field to make pagination stable.

	opt.Order = append(opt.Order, entity.Order{
		By:        entity.ComponentRepository,
		Direction: entity.OrderDirectionAsc,
	})

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.