fix(mcp): report our own version in the MCP handshake - #266
Merged
Conversation
`MCPServer`'s `version` parameter defaults to `""`, so the daemon-backed server advertised an empty `serverInfo.version`. Under the v1 SDK the field was auto-filled with the SDK's own version, which was already the wrong number to report — clients saw the MCP SDK release, not ours. Pass `_version.__version__`, the same value `ccc version`, the daemon handshake, and the version-mismatch check already use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #242.
MCPServer'sversionparameter defaults to""andcreate_mcp_servernever passed one, so the handshake advertises an emptyserverInfo.version— Claude Code's/mcpand MCP Inspector show nothing.This predates #242: v1's
FastMCPtook noversionargument and filled the field with the SDK's own release, so the handshake reported1.29.0. #242 turned a wrong value into an empty one; this reports the right one.It now passes
_version.__version__— the same valueccc versionprints (#245) and the daemon handshake compares against — so it can't drift. SingleMCPServer(...)call site, soccc mcpand the legacycocoindex-codeentry point both pick it up.Try it
test_mcp_server_reports_own_versionasserts the handshake value equals__version__.Operational impact
None — handshake metadata only. No protocol, settings, or on-disk change; no migration.
🤖 Generated with Claude Code