fix(tc): handle unauthenticated and already-accepted users#2582
Merged
olleolleolle merged 3 commits intocodebar:masterfrom Apr 22, 2026
Merged
fix(tc): handle unauthenticated and already-accepted users#2582olleolleolle merged 3 commits intocodebar:masterfrom
olleolleolle merged 3 commits intocodebar:masterfrom
Conversation
6f724d0 to
5295f5a
Compare
5295f5a to
20fa3c3
Compare
olleolleolle
approved these changes
Apr 22, 2026
Collaborator
olleolleolle
left a comment
There was a problem hiding this comment.
Nice to have!
I made a note on code formatting.
7 tasks
f556d78 to
7be548f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bug fixes for the Terms and Conditions page:
Bug: Unauthenticated users crash when submitting form
/terms_and_conditionsand click "Accept", which would crash becausecurrent_useris nilb28f8ebBug: Users who already accepted T&C see the form again
b56caa4Changes
app/controllers/terms_and_conditions_controller.rb- add login checkapp/views/terms_and_conditions/show.html.haml- conditional display for different statesconfig/locales/en.yml- new locale stringsspec/features/accepting_terms_and_conditions_spec.rb- new testsTesting