admin: improve group members page with pagination and search#2588
Open
mroderick wants to merge 3 commits intocodebar:masterfrom
Open
admin: improve group members page with pagination and search#2588mroderick wants to merge 3 commits intocodebar:masterfrom
mroderick wants to merge 3 commits intocodebar:masterfrom
Conversation
Rubocop's Lint/Syntax cop cannot parse HAML, causing false positives. This excludes HAML files only from Lint/Syntax, not all cops.
Adds a class method that returns group members sorted by their most recent workshop RSVP (most recent first, members with no RSVP at end). Includes test coverage for the new method.
- Adds column headings (Avatar, Name, Email, Mobile, T&C) - Adds T&C indicator using Font Awesome icons (green check / red x) - Adds TomSelect search dropdown for finding members by name/email - Adds Pagy pagination controls at bottom of table - Renders counts from instance variables to avoid N+1 queries
mroderick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the
/admin/groups/:idmembers page with:Screenshot from local with fake data
Why
With paging and search, these pages will be much more usable to organisers.
Top 3 chapters by member count
Before this change, organisers had to scroll through thousands of members on a single page.
Testing
Group.members_by_recent_rsvpscopeChecklist