You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Finding: major crates/localityd/src/reconcile.rs:106
The new eager Slack path can enqueue Prefetch for a target that already has a higher-priority hydration job, but persistence is keyed only by (mount_id, remote_id). queue_hydration merges priority correctly in memory, then still upserts the incoming lower-priority request to SQLite, overwriting the persisted reason. If the daemon restarts before the in-memory queue drains, an interactive FileOpen/explicit pull can come back as low-priority Prefetch, delaying foreground hydration behind Slack backlog.
Minimal fix: when enqueueing a duplicate target, persist the effective merged request instead of the incoming request, or skip the SQLite upsert when the incoming request loses to an existing higher-priority job. Add a regression test that queues a foreground hydration, then a Slack eager Prefetch for the same target, reloads persisted hydration jobs, and verifies the foreground reason is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation