survive_default_devices: Fix lighthousedb.json failed to parse JSON #361
Open
Acridine wants to merge 2 commits into
Open
survive_default_devices: Fix lighthousedb.json failed to parse JSON #361Acridine wants to merge 2 commits into
Acridine wants to merge 2 commits into
Conversation
Acridine
changed the title
bl4ckb0ne
requested changes
May 8, 2026
bl4ckb0ne
left a comment
bl4ckb0ne
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking care of this issue, and apologies for not answering to your issue sooner
| char *ct0conf = (char *)malloc(len); | ||
| size_t read = fread(ct0conf, 1, len, fp); | ||
| survive_load_steamvr_lighthousedb(ctx, ct0conf, len); | ||
| char *ct0conf = malloc(len + 1); |
Collaborator
There was a problem hiding this comment.
Prefer calloc to allocate memory, it also 0's the allocation to get no surprises. Plus you get the trailing \0 for free.
| survive_load_steamvr_lighthousedb(ctx, ct0conf, len); | ||
| char *ct0conf = malloc(len + 1); | ||
| size_t read = fread(ct0conf, 1, len, fp); | ||
| if (read != len) { |
Collaborator
There was a problem hiding this comment.
This could use a call to ferror or at least indicate that the read failed.
Comment on lines
627
to
628
| free(ct0conf); | ||
| fclose(fp); |
Collaborator
There was a problem hiding this comment.
This is now leaking on the normal path, those should be called after survive_load_steamvr_lighthousedb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #359, where the parsing of a
lighthousedb.jsongenerated with SteamVR fails.Root Cause
Missing null-termination ('\0') and unchecked partial fread() results.
Changes
In survive_default_devices.c:
fread()reads the full file before parsing.