fix: use default version fallback for scheduled safe-settings runs - #219
Merged
marcusburghardt merged 1 commit intoSep 7, 2026
Conversation
marcusburghardt
requested review from
gxmiranda,
jflowers and
jpower432
as code owners
September 7, 2026 07:33
Schedule triggers do not populate workflow_dispatch inputs, so inputs.version is empty. This causes actions/checkout to fall back to the repository default branch (main-enterprise), which uses Probot v14 and crashes with the null logger bug (#955). Extract the pinned version SHA into SAFE_SETTINGS_DEFAULT_VERSION env variable and use it as a fallback in the checkout ref. This ensures scheduled runs use the same v2.1.18 pin as manual dispatch. The env variable comment documents both upstream bugs blocking an upgrade (#955 and #818) for periodic manual review. Also set persist-credentials: false on both checkout steps to satisfy zizmor artipacked audit (credentials are not needed after checkout). Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
force-pushed
the
fix/safe-settings-schedule-version
branch
from
September 7, 2026 11:22
0a37f4b to
39bd902
Compare
Member
Author
|
@gxmiranda I needed to update the PR in order to solve the Lint issue. I basically included |
marcusburghardt
enabled auto-merge (rebase)
September 7, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the daily scheduled Safe Settings Sync workflow which fails because
inputs.versionis empty on schedule triggers (onlyworkflow_dispatchpopulates inputs).
Root Cause
With an empty
ref,actions/checkoutfalls back to the upstreamrepository default branch (
main-enterprise), which uses Probot v14.Probot v14 has a null logger bug
(#955)
that crashes immediately:
Fix
Extract the pinned version SHA into a
SAFE_SETTINGS_DEFAULT_VERSIONenv variable and use it as a fallback in the checkout step:
This ensures scheduled runs use the same v2.1.18 pin as manual dispatch.
Upgrade tracking
The env variable comment documents both upstream bugs blocking an
upgrade, for periodic manual review:
Failed run: https://github.com/complytime/.github/actions/runs/34018478903