chore: update uf scaffolded files and fix stale references by marcusburghardt · Pull Request #849 · complytime/complyctl

marcusburghardt · 2026-09-08T10:07:23Z

Summary

Update all unbound-force scaffolded files to the latest version and fix stale command references in user-owned files.

Changes

Commit 1: `chore: update uf scaffolded files to latest version`

Migrate command files to uf.* namespace (8 renamed/migrated)
Add new commands: address-feedback, triage-issue
Add new skills: pre-flight, review-context
Add new convention packs: ci, python (with custom variants)
Update existing packs, skills, and openspec schemas
Add dewey MCP server to opencode.json

Commit 2: `fix: update stale command references and remove website gate`

AGENTS.md: /review-council -> /uf.review-council
AGENTS.md: /review-pr -> /uf.review-pr
cobalt-crush-dev.md: /review-council -> /uf.review-council
Remove the Website gate behavioral rule that instructed agents to file issues in unbound-force/website (wrong repository)

Commit 3: `chore: force-update uf scaffolded agents and packs`

divisor-curator: dynamic repo detection via gh repo view instead of hardcoded unbound-force/website
divisor-adversary: expanded security audit checklist
All agents: updated version stamps and permission models
New: reviewer-testing agent, .specify/.gitignore
Restored project-specific go-custom.md rules (CR-001, CR-002)

Fixes

Fixes #745

Testing

These are agent/tooling configuration files only -- no source code changes. Verified:

No stale unbound-force/website references remain in AGENTS.md
No stale /review-council or /review-pr references remain in user-owned files
go-custom.md CR-001/CR-002 project-specific rules preserved after force update

em-redhat

Review: `chore: update uf scaffolded files and fix stale references`

CI Status

All 28 checks pass — unit, e2e, integration, cross-repo, acceptance, acceptance-verify, buf-lint, linters, Trivy, OSV-Scanner, Scorecards, CRAP Load, rpm-build, testing-farm. No Go source code changed.

#745 Fix

Correct. The Website gate behavioral rule is removed from AGENTS.md, and divisor-curator.md replaces all hardcoded unbound-force/website references with dynamic repo detection via gh repo view --json nameWithOwner. All 14 old references are in removed lines only.

Positive observations

Curator security improvement: divisor-curator.md switches from tools: bash: true to granular permissions (gh repo view*: allow, gh issue create*: ask) — meaningful defense-in-depth.
Adversary checklist expansion: Concurrency correctness, adversarial input enumeration, and CI bot corroboration sections are substantive review quality improvements.
Cobalt-crush pre-conditions: New dirty-working-tree check before branch switches is a good safety net.
Command namespace migration: Clean — old commands deleted, renames tracked, AGENTS.md table updated to uf.* names.

Two findings noted as inline comments — neither blocks merge but both are worth addressing in a follow-up.

em-redhat · 2026-09-08T13:19:14Z

+
+# Role: The Tester
+
+You are a test quality and testability auditor for the gaze project — a Go static analysis tool that detects observable side effects in functions, computes CRAP (Change Risk Anti-Patterns) scores by combining cyclomatic complexity with test coverage, and assesses test quality through contract coverage analysis.


This agent is scaffolded by gaze v1.8.0 (every other file in this PR uses uf v0.17.0) and describes itself as a testability auditor for the gaze project. Several items conflict with complyctl's conventions:

"no testify, gomega, or external assertion libraries" policy (complyctl mandates testify per AGENTS.md)

References to .specify/memory/constitution.md and specs/ (speckit paths — complyctl uses openspec)

testdata/src/ loaded via go/packages (gaze convention, not complyctl)

"Principle IV: Testability" from a constitution that doesn't exist in this repo

It also shares the "The Tester" role name with divisor-testing.md. No command references it so it's inert, but AGENTS.md zero-waste rule discourages orphaned artifacts.

Suggestion: Remove from this PR or replace with a complyctl-appropriate version in a follow-up.

Addressed in 1632a8e5: Removed reviewer-testing.md. It was scaffolded by gaze (not uf), conflicted with complyctl conventions (testify mandate, openspec paths), shared the "Tester" role name with divisor-testing.md, and was inert (zero-waste violation).

em-redhat · 2026-09-08T13:19:14Z

+   > author pushes any new commits after this APPROVE, it
+   > will be automatically invalidated and the PR will
+   > return to REVIEW_REQUIRED. You may need to re-run
+   > `/review-council` after final commits."


Stale reference — should be /uf.review-council since review-council.md is deleted in this PR. Same issue on line 596 (_This review was generated by /review-council).

Addressed in 1632a8e5: Fixed both stale /review-council references (lines 528, 596) to /uf.review-council. Note: this file is uf-scaffolded, so the fix will be overwritten on next uf init --force — the upstream template still has the stale references.

@em-redhat

Remove reviewer-testing.md scaffolded by gaze v1.8.0: - Conflicts with complyctl conventions (prohibits testify, references speckit paths, gaze-specific test patterns) - Shares "The Tester" role name with divisor-testing.md - No command references it (inert/orphaned artifact) - Violates AGENTS.md zero-waste behavioral rule Fix stale /review-council references in uf.review-council.md (lines 528, 596) to use /uf.review-council namespace. Addresses PR complytime#849 review feedback from @em-redhat. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>

@em-redhat

Remove reviewer-testing.md scaffolded by gaze v1.8.0: - Conflicts with complyctl conventions (prohibits testify, references speckit paths, gaze-specific test patterns) - Shares "The Tester" role name with divisor-testing.md - No command references it (inert/orphaned artifact) - Violates AGENTS.md zero-waste behavioral rule Fix stale /review-council references in uf.review-council.md (lines 528, 596) to use /uf.review-council namespace. Addresses PR complytime#849 review feedback from @em-redhat. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>

em-redhat

Both findings from the previous review have been addressed in 1632a8e:

reviewer-testing.md (orphaned gaze agent) — removed
Stale /review-council references in uf.review-council.md — updated to /uf.review-council

CI passes on the latest commit (23 SUCCESS, 3 SKIPPED, 2 NEUTRAL).

This review was generated by /review-pr (AI-assisted).

Run `uf init` to update tool-managed files: - Migrate command files to uf.* namespace (8 renamed/migrated) - Add new commands: address-feedback, triage-issue - Add new skills: pre-flight, review-context - Add new convention packs: ci, python (with custom variants) - Update existing packs, skills, and openspec schemas - Add dewey MCP server to opencode.json - Add dcp.jsonc configuration Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>

Update command references to match the new uf.* namespace: - AGENTS.md: /review-council -> /uf.review-council - AGENTS.md: /review-pr -> /uf.review-pr - cobalt-crush-dev.md: /review-council -> /uf.review-council Remove the Website gate behavioral rule that incorrectly instructed agents to file issues in unbound-force/website, which is an unrelated repository. Fixes complytime#745 Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>

Run `uf init --force` to overwrite all skipped agent and pack files with latest upstream versions. Key changes: - divisor-curator: dynamic repo detection via `gh repo view` instead of hardcoded `unbound-force/website` target - divisor-adversary: expanded security audit checklist - cobalt-crush-dev: updated review-council reference - All agents: updated version stamps and permission models - New: reviewer-testing agent, .specify/.gitignore - Restored project-specific go-custom.md rules (CR-001, CR-002) Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>

@em-redhat

Remove reviewer-testing.md scaffolded by gaze v1.8.0: - Conflicts with complyctl conventions (prohibits testify, references speckit paths, gaze-specific test patterns) - Shares "The Tester" role name with divisor-testing.md - No command references it (inert/orphaned artifact) - Violates AGENTS.md zero-waste behavioral rule Fix stale /review-council references in uf.review-council.md (lines 528, 596) to use /uf.review-council namespace. Addresses PR complytime#849 review feedback from @em-redhat. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>

yvonnedevlinrh

LGTM

I created a ticket to update the stale references in some of the scaffolded files in unbound-force as they would only get overwritten here otherwise. I also created a ticket for the docs references in complyctl
unbound-force/unbound-force#589
https://github.com/complytime/complyctl/issues/853

@em-redhat

Remove reviewer-testing.md scaffolded by gaze v1.8.0: - Conflicts with complyctl conventions (prohibits testify, references speckit paths, gaze-specific test patterns) - Shares "The Tester" role name with divisor-testing.md - No command references it (inert/orphaned artifact) - Violates AGENTS.md zero-waste behavioral rule Fix stale /review-council references in uf.review-council.md (lines 528, 596) to use /uf.review-council namespace. Addresses PR complytime#849 review feedback from @em-redhat. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>

marcusburghardt requested a review from a team as a code owner September 8, 2026 10:07

marcusburghardt requested review from hbraswelrh and trevor-vaughan September 8, 2026 10:07

marcusburghardt added this to the ComplyTime improvements milestone Sep 8, 2026

marcusburghardt added this to ComplyTime planning Sep 8, 2026

github-project-automation Bot moved this to Backlog in ComplyTime planning Sep 8, 2026

marcusburghardt moved this from Backlog to Ready for Review 👀 in ComplyTime planning Sep 8, 2026

marcusburghardt requested review from em-redhat and yvonnedevlinrh and removed request for hbraswelrh and trevor-vaughan September 8, 2026 10:08

em-redhat previously approved these changes Sep 8, 2026

View reviewed changes

marcusburghardt dismissed em-redhat’s stale review via e83a84d September 8, 2026 14:00

marcusburghardt force-pushed the update-uf branch from e83a84d to 1632a8e Compare September 8, 2026 14:09

marcusburghardt requested a review from em-redhat September 8, 2026 14:11

em-redhat approved these changes Sep 8, 2026

View reviewed changes

marcusburghardt enabled auto-merge September 9, 2026 07:14

marcusburghardt requested a review from gxmiranda September 10, 2026 09:06

marcusburghardt added the enhancement New feature or request label Sep 10, 2026

yvonnedevlinrh mentioned this pull request Sep 10, 2026

Update stale command references in docs/AI_TOOLING.md post uf.* namespace migration complytime/org-infra#583

Closed

2 tasks

marcusburghardt added 4 commits September 10, 2026 15:06

yvonnedevlinrh force-pushed the update-uf branch from 1632a8e to 21563fb Compare September 10, 2026 14:06

yvonnedevlinrh approved these changes Sep 10, 2026

View reviewed changes

marcusburghardt merged commit 6abc690 into complytime:main Sep 10, 2026
22 of 28 checks passed

marcusburghardt deleted the update-uf branch September 10, 2026 14:13

github-project-automation Bot moved this from Ready for Review 👀 to Done ✔️ in ComplyTime planning Sep 10, 2026

marcusburghardt mentioned this pull request Sep 10, 2026

[Task] Update scaffolded files in complytime repositories unbound-force/unbound-force#591

Open

2 tasks

Navigation Menu

Uh oh!

chore: update uf scaffolded files and fix stale references - #849

chore: update uf scaffolded files and fix stale references#849
marcusburghardt merged 4 commits into
complytime:mainfrom
marcusburghardt:update-uf

marcusburghardt commented Sep 8, 2026

Uh oh!

em-redhat left a comment

Uh oh!

em-redhat Sep 8, 2026

Uh oh!

marcusburghardt Sep 8, 2026

Uh oh!

em-redhat Sep 8, 2026

Uh oh!

marcusburghardt Sep 8, 2026

Uh oh!

em-redhat left a comment

Uh oh!

yvonnedevlinrh left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		# Role: The Tester

		You are a test quality and testability auditor for the gaze project — a Go static analysis tool that detects observable side effects in functions, computes CRAP (Change Risk Anti-Patterns) scores by combining cyclomatic complexity with test coverage, and assesses test quality through contract coverage analysis.

Uh oh!

Conversation

marcusburghardt commented Sep 8, 2026

Summary

Changes

Commit 1: chore: update uf scaffolded files to latest version

Commit 2: fix: update stale command references and remove website gate

Commit 3: chore: force-update uf scaffolded agents and packs

Fixes

Testing

Uh oh!

em-redhat left a comment

Choose a reason for hiding this comment

Review: chore: update uf scaffolded files and fix stale references

CI Status

#745 Fix

Positive observations

Uh oh!

em-redhat Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

marcusburghardt Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

em-redhat Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

marcusburghardt Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

em-redhat left a comment

Choose a reason for hiding this comment

Uh oh!

yvonnedevlinrh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Commit 1: `chore: update uf scaffolded files to latest version`

Commit 2: `fix: update stale command references and remove website gate`

Commit 3: `chore: force-update uf scaffolded agents and packs`

Review: `chore: update uf scaffolded files and fix stale references`