perf: Add per-workflow /versions API with lazy UI version loading#1019
Draft
akhilpathivada wants to merge 1 commit intoconductor-oss:mainfrom
Draft
perf: Add per-workflow /versions API with lazy UI version loading#1019akhilpathivada wants to merge 1 commit intoconductor-oss:mainfrom
akhilpathivada wants to merge 1 commit intoconductor-oss:mainfrom
Conversation
Signed-off-by: akhilpathivada <akhil.pathivada.21@gmail.com>
akhilpathivada
force-pushed
the
feature/lazy-workflow-versions
branch
from
ce8317f to
30e59f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1014
Summary
GET /metadata/workflow/{name}/versionsendpoint returning lightweightversion summaries (version number + createTime) without deserializing full
workflow definition JSON bodies
SaveWorkflowDialog) to fetch versions lazily when a workflow is selected,
instead of loading all ~600K version summaries on every page load
Motivation
At 200K+ workflow definitions, the existing
/names-and-versionsendpoint loads all version summaries upfront on everypage load. This PR fetches only the 3-5 versions needed for the selected
workflow, on demand.
Test plan
MetadataServiceTest.testGetWorkflowVersions— unit test (mocked DAO)PostgresMetadataDAOTest.testGetWorkflowVersions— integration test (Testcontainers)MetadataResourceTest.testGetWorkflowVersions— REST controller test/metadata/workflow/*/versionsloads lazily with loading indicator