test/system: Simplify capturing standard error from command substitution#1821
Merged
Conversation
This removes the nested subshell and saves spawning an extra process to achieve the exact same result. As suggested by Gemini Code Assist. Fallout from 61e2c97 and 2e7ba83 containers#1821
debarshiray
force-pushed
the
wip/rishi/test-system-libs-drop-double-subshell-for-command-substitution-stderr
branch
from
90a9af6 to
b9b6d0c
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the command substitution in test/system/libs/helpers.bash by removing an unnecessary subshell and correcting the redirection order to properly capture stderr while discarding stdout. There are no review comments, so no additional feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Fallout from 5c0372e and 54a2ca1 containers#1821
debarshiray
deleted the
wip/rishi/test-system-libs-drop-double-subshell-for-command-substitution-stderr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the nested subshell and saves spawning an extra process to achieve the exact same result.
As suggested by Gemini Code Assist.
Fallout from 61e2c97 and 2e7ba83