fix: use absolute post canonical urls#6226
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
idoshamun
force-pushed
the
codex/fix-post-canonical-urls
branch
from
5b926ae to
9db13a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
https://daily.devwhenNEXT_PUBLIC_WEBAPP_URLis relative.Why
Post detail surfaces were overriding the app-wide absolute canonical with
webappUrl, which can resolve to/, causing<link rel="canonical">and fallbackog:urlto render as relative paths.Validation
pnpm --filter webapp exec eslint lib/seo.ts 'pages/posts/[id]/index.tsx' 'pages/posts/[id]/share/index.tsx' 'pages/posts/[id]/analytics/index.tsx' --ext .ts,.tsx --max-warnings 0git diff --checkKnown CI
typecheck_strict_changedfails on existing strict-null issues in the touched post share/analytics files. Those fixes were intentionally removed to keep this PR limited to canonical URL behavior.Preview domain
https://codex-fix-post-canonical-urls.preview.app.daily.dev