Fix computed field inheritance with pydantic 2.13 - #328
Open
noamkush wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 92.21% 92.22%
=======================================
Files 31 31
Lines 1786 1788 +2
=======================================
+ Hits 1647 1649 +2
Misses 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue we bumped into when trying to update to pydantic 2.13. See the tests - any use of
computed_attrorcomputed_elementin a base class results in an exception (on import). Both tests fail with currentmasterbranch. The implementation usesdataclasses.replacewhich differs from the base implementation to avoid repeating the many fields that need to be copied. This would probably be easier to maintain.I used an LLM to make the code changes.
The error's stack trace looks like this