Add unit tests for ActorRuntime reminder/timer invocation and close() - #1796
Open
manduinca wants to merge 1 commit into
Open
Add unit tests for ActorRuntime reminder/timer invocation and close()#1796manduinca wants to merge 1 commit into
manduinca wants to merge 1 commit into
Conversation
Covers ActorRuntime.invokeReminder and invokeTimer (happy path and unregistered actor type), close() with and without an already-shutdown channel, the single-instance constructor guard, duplicate actor registration, and deactivate for an unregistered type. Also adds ActorProxyImpl tests for @ACTORmethod(name) renaming and for serialization/deserialization failures wrapped as DaprException. Part of dapr#369 Signed-off-by: Jean Pierre Mandujano G. <jeanpierre.mandujano@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1796 +/- ##
============================================
+ Coverage 77.10% 77.27% +0.16%
- Complexity 2317 2328 +11
============================================
Files 245 245
Lines 7186 7186
Branches 750 750
============================================
+ Hits 5541 5553 +12
+ Misses 1284 1272 -12
Partials 361 361 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #1790, part of #369. Adds the remaining coverage for
sdk-actors:ActorRuntimeTest (9 new tests):
invokeReminderandinvokeTimer: happy path (verifying the actor callback actually receives the deserialized payload) and unregistered actor type.close(): shuts down the managed channel, and skips shutdown when the channel is already shut down.IllegalStateException).deactivatewith an unregistered actor type.ActorProxyImplTest (3 new tests):
@ActorMethod(name = ...)renaming reaches the client with the renamed method.DaprException.Issue reference
Part of #369
Checklist