Some fixes related to unified OpenCL memory#21354
Open
jenshannoschwalm wants to merge 1 commit into
Open
Conversation
1. The remaining total system memory was wrongfully decreased too far when using unified cl memory possibly leading to decreased performance, also wrong log reports later on. 2. The available memory restrictions due to OpenCL and the resource level are calculated now inside dt_opencl_update_setting(), this is called at startup and when changing preferences so cl_mem setting are always up-to-date and logged there. 3. Checks for available cl_mem when allocating buffers/images have been fixed, relevant for small devices with unified memory. 4. Simplified pipe starting logs, we don't do checks there any more as we do that in (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dt_opencl_update_setting(), this is called at startup and when changing preferences so cl_mem setting are always up-to-date and logged there.