Skip to content

Some fixes related to unified OpenCL memory#21354

Open
jenshannoschwalm wants to merge 1 commit into
darktable-org:masterfrom
jenshannoschwalm:unified_clmem
Open

Some fixes related to unified OpenCL memory#21354
jenshannoschwalm wants to merge 1 commit into
darktable-org:masterfrom
jenshannoschwalm:unified_clmem

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator
  1. The remaining total system memory was wrongfully decreased too far when using unified cl memory possibly leading to decreased performance, also wrong log reports later on.
  2. The available memory restrictions due to OpenCL and the resource level are calculated now inside dt_opencl_update_setting(), this is called at startup and when changing preferences so cl_mem setting are always up-to-date and logged there.
  3. Checks for available cl_mem when allocating buffers/images have been fixed, relevant for small devices with unified memory.
  4. Simplified pipe starting logs, we don't do checks there any more as we do that in (2)

1. The remaining total system memory was wrongfully decreased too far when using unified cl memory
   possibly leading to decreased performance, also wrong log reports later on.
2. The available memory restrictions due to OpenCL and the resource level are calculated now inside
   dt_opencl_update_setting(), this is called at startup and when changing preferences so cl_mem
   setting are always up-to-date and logged there.
3. Checks for available cl_mem when allocating buffers/images have been fixed, relevant for small
   devices with unified memory.
4. Simplified pipe starting logs, we don't do checks there any more as we do that in (2)
@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Jun 19, 2026
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code labels Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant