Skip to content

Seperate scanner helper table initialisation - #38

Merged
darrell-k merged 1 commit into
image-scanning-new-approachfrom
initialise-scanner-tables
Sep 3, 2026
Merged

Seperate scanner helper table initialisation#38
darrell-k merged 1 commit into
image-scanning-new-approachfrom
initialise-scanner-tables

Conversation

@darrell-k

Copy link
Copy Markdown
Owner

@michaelherger , what do you think?

Signed-off-by: darrell-k <darrell@darrell.org.uk>
@michaelherger

Copy link
Copy Markdown

What would be the benefit of this change?

@darrell-k

darrell-k commented Sep 3, 2026

Copy link
Copy Markdown
Owner Author

Prevents schema_scanner.sql being run multiple times at the beginning of the scanner process. When the call is in migrateDB, it runs 3 times in a n&c: initially, then when FTS SQL functions are registered and when the new SQL functions we discussed earlier are registered; and 4 times in a full rescan (additionally from wipeDB).

@michaelherger

Copy link
Copy Markdown

The same applies to the schema migration, doesn't it? It's still wasteful there. Is it worth the change? Oh well, simple enough.

@michaelherger

Copy link
Copy Markdown

Oh, I can't merge - this is all your repository 😁.

@darrell-k

Copy link
Copy Markdown
Owner Author

I'll merge it, then it will appear in LMS-Community#1637

I don't think the rest of migrateDB does anything unless a schema change is detected.

@darrell-k
darrell-k merged commit e74c9c5 into image-scanning-new-approach Sep 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants