Skip to content

Fix --force-pull on bundle summary and bundle open#5028

Open
simonfaltum wants to merge 1 commit intomainfrom
simonfaltum/bundle-force-pull-fix
Open

Fix --force-pull on bundle summary and bundle open#5028
simonfaltum wants to merge 1 commit intomainfrom
simonfaltum/bundle-force-pull-fix

Conversation

@simonfaltum
Copy link
Copy Markdown
Member

Why

--force-pull on bundle summary and bundle open is silently ignored: both commands declare the flag but never pass it through, so the local state cache is used even when the user explicitly asks for a remote pull. Users see stale URLs or IDs and have no way to bypass the cache short of deleting .databricks/ by hand.

The flag works as expected on pipelines open and bundle debug states.

Changes

Wire forcePull into ProcessOptions.AlwaysPull in cmd/bundle/summary.go and cmd/bundle/open.go so the flag reaches statemgmt.PullResourcesState. This matches the pattern used in the two commands where the flag already works.

No behavior change when the flag is unset.

Test plan

  • New acceptance test acceptance/bundle/state/force_pull_commands/ asserts that a workspace-files state GET is issued only when --force-pull is set, for both bundle summary and bundle open. Runs under both engines via EnvMatrix.
  • Reverted the fix locally and confirmed the test fails with the expected diff (missing state GETs), then restored.
  • `make checks` clean; state/help/open/summary/pipelines-open acceptance suites all pass.

Both commands declared the flag but never passed it into
ProcessOptions.AlwaysPull, so it silently no-oped and users were served
stale local state. Wire forcePull into AlwaysPull in both commands to
match the pattern in pipelines open and bundle debug states.

Co-authored-by: Isaac
@github-actions
Copy link
Copy Markdown

Approval status: pending

/acceptance/bundle/ - needs approval

7 files changed
Suggested: @denik
Also eligible: @andrewnester, @pietern, @lennartkats-db, @shreyas-goenka, @janniklasrose, @anton-107

/cmd/bundle/ - needs approval

Files: cmd/bundle/open.go, cmd/bundle/summary.go
Suggested: @denik
Also eligible: @andrewnester, @pietern, @lennartkats-db, @shreyas-goenka, @janniklasrose, @anton-107

General files (require maintainer)

Files: NEXT_CHANGELOG.md
Based on git history:

  • @denik -- recent work in ./, cmd/bundle/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

@simonfaltum simonfaltum requested a review from denik April 20, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant