[2/7] Add native batching configuration and parameter model - #1621
Open
sreekanth-db wants to merge 2 commits into
Open
[2/7] Add native batching configuration and parameter model#1621sreekanth-db wants to merge 2 commits into
sreekanth-db wants to merge 2 commits into
Conversation
Keep existing batching behavior behind a dedicated executor so native routing can be added without changing the compatibility fallback. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Introduce a dormant opt-in and deterministic parameter snapshots so both native transports can share the same ordered payload without changing execution behavior. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Looks good — clean, well-tested dormant foundation (config flag + immutable ordered parameter-set model with defensive value snapshotting). One low-severity note: the model uses zero-based wire ordinals while the current SEA path is one-based, worth verifying before the execution path is wired up.
Scope: reviewed as a stacked increment (520eb7f..head); the parent's changes are reviewed on the parent PR.
|
JDBC integration tests triggered ( |
This was referenced Aug 10, 2026
sreekanth-db
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Description
Add the dormant foundation for native parameter batching.
EnableNativeBatching, disabled by default.This PR does not change batch execution or send native requests.
Testing
jdbc-coresuite: 3,611 passed, 88 skipped.Additional Notes to the Reviewer
No telemetry field is included because that requires the corresponding backend telemetry proto change.
NO_CHANGELOG=true