Skip to content

Fix -Werror build failure from unused isProtectedDataAvailableAsync - #358

Open
NSExceptional wants to merge 1 commit into
masterfrom
fix/build-unused-function
Open

Fix -Werror build failure from unused isProtectedDataAvailableAsync#358
NSExceptional wants to merge 1 commit into
masterfrom
fix/build-unused-function

Conversation

@NSExceptional

@NSExceptional NSExceptional commented Aug 7, 2026

Copy link
Copy Markdown

The Xcode 26 recommended project settings adopted in #355 enable -Wunused-function and treat warnings as errors. isProtectedDataAvailableAsync in TSKSPKIHashCache.m is defined but never called, so the iOS build now fails with:

TSKSPKIHashCache.m:166:13: error: unused function 'isProtectedDataAvailableAsync' [-Werror,-Wunused-function]

The function is intentionally kept for an upcoming rewrite, so rather than removing it this PR marks it __attribute__((unused)) to silence the warning. Verified the TrustKit iOS scheme builds successfully afterward.

@NSExceptional
NSExceptional requested a review from a team August 7, 2026 00:28
@NSExceptional NSExceptional mentioned this pull request Aug 7, 2026
…sync

The Xcode 26 recommended settings adopted in #355 enable -Wunused-function as an error, breaking the iOS build. isProtectedDataAvailableAsync in TSKSPKIHashCache.m is intentionally kept for an upcoming rewrite, so mark it __attribute__((unused)) rather than removing it.
@NSExceptional
NSExceptional force-pushed the fix/build-unused-function branch from a528284 to ea4d01a Compare August 7, 2026 00:31

@alexanderdibenedetto alexanderdibenedetto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants