Fix -Werror build failure from unused isProtectedDataAvailableAsync - #358
Open
NSExceptional wants to merge 1 commit into
Open
Fix -Werror build failure from unused isProtectedDataAvailableAsync#358NSExceptional wants to merge 1 commit into
NSExceptional wants to merge 1 commit into
Conversation
Open
…sync The Xcode 26 recommended settings adopted in #355 enable -Wunused-function as an error, breaking the iOS build. isProtectedDataAvailableAsync in TSKSPKIHashCache.m is intentionally kept for an upcoming rewrite, so mark it __attribute__((unused)) rather than removing it.
NSExceptional
force-pushed
the
fix/build-unused-function
branch
from
August 7, 2026 00:31
a528284 to
ea4d01a
Compare
uroboro
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xcode 26 recommended project settings adopted in #355 enable
-Wunused-functionand treat warnings as errors.isProtectedDataAvailableAsyncinTSKSPKIHashCache.mis defined but never called, so the iOS build now fails with:The function is intentionally kept for an upcoming rewrite, so rather than removing it this PR marks it
__attribute__((unused))to silence the warning. Verified theTrustKitiOS scheme builds successfully afterward.