Skip to content

add clear cache button to clear local stores easily + automatic clearing upon version bump#627

Open
joehart2001 wants to merge 3 commits into
mainfrom
clear-storage
Open

add clear cache button to clear local stores easily + automatic clearing upon version bump#627
joehart2001 wants to merge 3 commits into
mainfrom
clear-storage

Conversation

@joehart2001

@joehart2001 joehart2001 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Linked issue

Resolves #

Testing

@joehart2001 joehart2001 added the enhancement New feature or request label Jun 18, 2026

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

What's the benefit of client-side callbacks vs some sort of pattern-matching explicit clear as a Python callback?

I also think there may be a bug in the storage, since the weights etc. don't seem to be persisted once I close the tab. I'm not sure that's introduced here, but it makes it harder to test the version clear since I think it happens anyway.

I'd probably also make the button more prominent, perhaps next to the tutorial button? It's quite out of the way currently.

@joehart2001

Copy link
Copy Markdown
Collaborator Author

Nice!

What's the benefit of client-side callbacks vs some sort of pattern-matching explicit clear as a Python callback?

I also think there may be a bug in the storage, since the weights etc. don't seem to be persisted once I close the tab. I'm not sure that's introduced here, but it makes it harder to test the version clear since I think it happens anyway.

I'd probably also make the button more prominent, perhaps next to the tutorial button? It's quite out of the way currently.

  • yep the bug is on the live site too, i think we need to move the wieghts and threhsolds to local storage?
  • changed the location
  • the clear is a browser operation: localStorage.clear(), sessionStorage.clear(), and window.location.reload() which a python callback cant do
  • added a progress for the loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants