Skip to content

feat(images): add InUse condition - #1184

Draft
eofff wants to merge 11 commits into
mainfrom
feat/images/show-usages-while-terminating
Draft

feat(images): add InUse condition#1184
eofff wants to merge 11 commits into
mainfrom
feat/images/show-usages-while-terminating

Conversation

@eofff

@eofff eofff commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add new condition InUse
Add new handler to set InUse condition

Why do we need it, and what problem does it solve?

Other resources may use VI/CVI for creation, we must not delete VI/CVI while they are in use.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: images
type: feature
summary: Do not allow the deletion of VI/CVI that are in use.

@eofff
eofff force-pushed the feat/images/show-usages-while-terminating branch 2 times, most recently from 3a9407e to 9cbcda6 Compare June 24, 2025 15:40
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 24, 2025
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 24, 2025
@eofff eofff added this to the v0.21.0 milestone Jun 25, 2025
@nevermarine nevermarine modified the milestones: v0.21.0, v0.22.0 Jun 26, 2025
@eofff
eofff force-pushed the feat/images/show-usages-while-terminating branch from ca68426 to 655634a Compare June 26, 2025 20:49
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Workflow has started.
Follow the progress here: Workflow Run

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@eofff
eofff force-pushed the feat/images/show-usages-while-terminating branch from 655634a to ca04dec Compare June 27, 2025 06:42
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@deckhouse-BOaTswain

deckhouse-BOaTswain commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@eofff
eofff marked this pull request as ready for review June 27, 2025 08:35
eofff added 5 commits September 4, 2025 10:35
@eofff
fix finalizers logic
35d7ec9 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff
fix vmbda watching
a0f26bd 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff
fix watchers
61ac8c9 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff
fix vi vd watcher
27d3eeb 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff
fix test
650f344 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff
eofff force-pushed the feat/images/show-usages-while-terminating branch from 29505a7 to 650f344 Compare September 4, 2025 07:35
@Isteb4k Isteb4k closed this Sep 4, 2025
@Isteb4k
Isteb4k deleted the feat/images/show-usages-while-terminating branch September 4, 2025 07:48
@Isteb4k
Isteb4k restored the feat/images/show-usages-while-terminating branch September 4, 2025 07:52
@eofff eofff reopened this Sep 4, 2025
@eofff
fix builders
4f1a2e5 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@Isteb4k
Isteb4k marked this pull request as draft September 4, 2025 08:56
@nevermarine nevermarine modified the milestones: v1.0.0, v1.1.0 Sep 11, 2025
@nevermarine nevermarine modified the milestones: v1.1.0, v1.2.0 Oct 6, 2025
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.1.1 Oct 14, 2025
@nevermarine nevermarine modified the milestones: v1.1.1, v1.2.0 Oct 16, 2025
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
@nevermarine nevermarine modified the milestones: v1.3.0, v1.4.0 Dec 16, 2025
@nevermarine nevermarine modified the milestones: v1.4.0, v1.5.0 Jan 23, 2026
@nevermarine nevermarine modified the milestones: v1.5.0, v1.6.0 Feb 9, 2026
@universal-itengineer universal-itengineer modified the milestones: v1.6.0, v1.7.0 Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner
@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner
@fl64 fl64 Awaiting requested review from fl64

At least 5 approving reviews are required to merge this pull request.

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v1.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@eofff @deckhouse-BOaTswain @nevermarine @Isteb4k @universal-itengineer