Resolve recurrent dead-code/docs items (DEVELOPMENT.md 4B)#102
Merged
Conversation
- Extract duplicated _validate_memory from ARA/ARI into a shared validate_memory helper in utils/recurrent_utils.py - Fix copy-pasted "Parameters of the Duane model" docstrings in CrowAMSAA to read "Crow-AMSAA model" - Fix has_left_censoing typo -> has_left_censoring in the NHPP parametric and proportional-intensity regression fitters https://claude.ai/code/session_01PeqiCJotMqG5ujuJdvVvzf
All dead-code/stubs/docs items in section 4B are now resolved, so drop the subsection. https://claude.ai/code/session_01PeqiCJotMqG5ujuJdvVvzf
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The has_left_censoring rename pushed the Z_left line to 80 chars; wrap it under the 79-char limit. https://claude.ai/code/session_01PeqiCJotMqG5ujuJdvVvzf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_memory helper in utils/recurrent_utils.py
CrowAMSAA to read "Crow-AMSAA model"
parametric and proportional-intensity regression fitters
https://claude.ai/code/session_01PeqiCJotMqG5ujuJdvVvzf