feat: make per-role reasoning effort configurable via settings - #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
effortsobject to~/.config/roc/settings.jsonthat overrides the per-role reasoning defaults (Scouthigh, Implementmedium, Reviewhigh), e.g.{"efforts": {"implement": "xhigh"}}.xhigh).onboardpreserves an existingeffortssetting when rewriting settings.modelsmapping.Why
The advisor currently hardcodes effort (
implement ? "medium" : "high"). Operators whose provider supports richer reasoning levels cannot raise effort for hard implementation tickets or lower it for cheap scouting, even when they know their model and workload better than the defaults. This keeps the defaults as opinions but adds the escape hatch.Design notes
medium/high/xhigh:minimal/lowhave no use in Roc's three-role pipeline, and on Anthropic-compatible channels Pi clampsmaxdown tohigh, soxhighis the highest level that reaches an OpenAI-style provider natively.xhighfalls back cleanly with the diagnostic;medium/highbehave as before.How to Test
bun run typecheckandbun run lintpass.bun run test: 335 tests pass including 3 new ones covering configured override + unset roles unchanged, xhigh chain advancement, and unsupported-effort fallback with diagnostics.parallel-pi, twotask-branchbase-refresh cases) time out at the 5s limit on this (slow, loaded) machine also on unmodified main — they are environment timeouts, not regressions; CI's faster runners should confirm.