feat(manip): add GraspGenX proposal provider - #3367
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3367 +/- ##
==========================================
+ Coverage 75.75% 75.81% +0.05%
==========================================
Files 1172 1178 +6
Lines 113650 113966 +316
Branches 10272 10287 +15
==========================================
+ Hits 86093 86399 +306
- Misses 24566 24572 +6
- Partials 2991 2995 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
90216db to
0b201b3
Compare
Greptile SummaryAdds an import-safe GraspGenX proposal provider and typed ranked-grasp messages while retaining the existing grasp orchestration contract during a transition.
Confidence Score: 4/5The PR does not appear safe to merge until the new GraspGenX provider is connected to a consumer that uses its ranked proposal contract. GraspingModule still requests LegacyGraspGenSpec and calls generate_grasps with object and scene clouds, while GraspGenXModule implements only GraspGenSpec.propose_grasps and returns GraspCandidateArray, so the previously reported integration path remains disconnected. Files Needing Attention: dimos/manipulation/grasping/grasp_gen_spec.py, dimos/manipulation/grasping/grasping.py, dimos/manipulation/grasping/grasp_gen_x.py Important Files Changed
Reviews (5): Last reviewed commit: "Merge branch 'main' into feat/grasp-02-p..." | Re-trigger Greptile |
Contribution path
Problem
The manipulation stack needs a typed, import-safe boundary for ranked grasp proposals. Without one, downstream planning code must depend directly on the optional GraspGenX runtime and cannot exchange candidates through stable DimOS message contracts.
Solution
GraspCandidateandGraspCandidateArraymessage contracts.This is stack 1 of 5. Base:
main. Next: #3363.How to Test
uv run pytest dimos/manipulation/grasping/test_grasp_gen_x.py dimos/msgs/manipulation_msgs/test_grasp_candidate.py -vVerified: 29 focused tests passed; Ruff and
git diff --checkpassed.AI assistance
OpenAI Codex with GPT-5 was used extensively for branch extraction, implementation cleanup, verification, and this description.
Checklist