fix(zenoh): route local sessions through the coordinator router - #3374
Draft
Nabla7 wants to merge 1 commit into
Draft
fix(zenoh): route local sessions through the coordinator router#3374Nabla7 wants to merge 1 commit into
Nabla7 wants to merge 1 commit into
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3374 +/- ##
==========================================
+ Coverage 75.80% 75.83% +0.02%
==========================================
Files 1172 1172
Lines 113568 113644 +76
Branches 10258 10269 +11
==========================================
+ Hits 86090 86180 +90
- Misses 24492 24521 +29
+ Partials 2986 2943 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ModuleCoordinator.Root cause
Independent peer sessions relied on multicast discovery. On macOS and restricted networks, sibling processes could fail to discover each other or lose reachability even though they belonged to one DimOS run.
The coordinator now owns the local routing topology while typed streams and RPC continue using the normal Zenoh implementations.
Validation
cargo fmtandcargo clippypassed