fix: add Gallery from gravity-ui, custom hook useGalleryOpen#653
Open
HelenVirtanen wants to merge 1 commit into
Open
fix: add Gallery from gravity-ui, custom hook useGalleryOpen#653HelenVirtanen wants to merge 1 commit into
HelenVirtanen wants to merge 1 commit into
Conversation
HelenVirtanen
requested review from
reazy015 and
stenin-nikita
and removed request for
a team
Contributor
|
Visual Tests Report is ready. |
HelenVirtanen
force-pushed
the
fix-gallery-img-video
branch
from
c51ac14 to
3648832
Compare
reazy015
reviewed
Jun 16, 2026
| iframeEl: HTMLIFrameElement | null; | ||
| }; | ||
|
|
||
| export function getGalleryItemVideo({index, iframeEl}: GetGalleryItemVideoArgs): GalleryItemProps { |
Contributor
There was a problem hiding this comment.
It looks more like a hook than a simple utility function.
BTW all hooks should be placed in separate dir - hooks
reazy015
reviewed
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GalleryandGalleryCorecomponents as a lightweight integration layer around@gravity-ui/componentsGalleryProvider.useGalleryOpenwith global event delegation. This enables users to click on any image or embedded video hosting player (within the.dc-doc-page__maincontainer) to open it in a rich full-screen slider modal with thumbnail navigation and link-sharing capabilities.interactivemode and customviewrendering to bypass native video tag constraints..dc-contributor-avatars__avatar) to ensure only core documentation media is aggregated.