fix: respect HOME env var when expanding ~ in paths#3088
Open
Divyansh670 wants to merge 1 commit into
Open
Conversation
aheritier
added
area/agent
Member
|
Looks good. Thanks for the contribution! |
Sayt-0
approved these changes
Jun 26, 2026
Member
|
One small thing: the commit ( |
Divyansh670
force-pushed
the
fix/windows-home-expansion
branch
from
c114ed6 to
25eb122
Compare
Author
|
Done ✅.
…On Fri, Jun 26, 2026, 8:35 PM Sayt0 ***@***.***> wrote:
*Sayt-0* left a comment (docker/docker-agent#3088)
<#3088 (comment)>
One small thing: the commit (c114ed6) is unsigned. This repo requires
commits to be signed with a GPG or SSH key. Could you re-sign and
force-push? Thanks!
—
Reply to this email directly, view it on GitHub
<#3088?email_source=notifications&email_token=A7ZTAKZAGWLWVZBLVTZFSQD5B2GLFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRGA3TQNBRGM32M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4810784137>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7ZTAK6WLTM6HQMS424I6Y35B2GLFAVCNFSNUABGKJSXA33TNF2G64TZHMYTANBYGQYTQMZZGQ5US43TOVSTWNBWGQ4TANZXGEYDTILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A7ZTAKZ2GDMXWHIAFK3WY6L5B2GLFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRGA3TQNBRGM32M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/A7ZTAK23D46JBOW4XK326HL5B2GLFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRGA3TQNBRGM32M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you were assigned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows test failure in pkg/tools/workingdir where HOME override was ignored because os.UserHomeDir() reads USERPROFILE instead.