Fix union & conditional directive (@skip and @include) not generating field types correctly

[eddeee888]

Description

When updating Codegen packages in Console, we saw that there are issues with generated types:

Given a document like this:

mutation schemaPublish($input: SchemaPublishInput!, $usesGitHubApp: Boolean!) {
    schemaPublish(input: $input) {
      __typename
      ... on SchemaPublishSuccess @skip(if: $usesGitHubApp) {
        initial
        valid
        successMessage: message
        linkToWebsite
        changes {
          edges {
            __typename
          }
          ...RenderChanges_schemaChanges
        }
      }
      ... on SchemaPublishError @skip(if: $usesGitHubApp) {
        valid
        linkToWebsite
        changes {
          edges {
            __typename
          }
          ...RenderChanges_schemaChanges
        }
        errors {
          ...RenderErrors_SchemaErrorConnectionFragment
        }
      }
      ... on SchemaPublishMissingServiceError @skip(if: $usesGitHubApp) {
        missingServiceError: message
      }
      ... on SchemaPublishMissingUrlError @skip(if: $usesGitHubApp) {
        missingUrlError: message
      }
      ... on GitHubSchemaPublishSuccess @include(if: $usesGitHubApp) {
        message
      }
      ... on GitHubSchemaPublishError @include(if: $usesGitHubApp) {
        message
      }
      ... on SchemaPublishRetry {
        reason
      }
    }
  }

In @graphql-codegen/client-preset@5.1.1:

This is incorrect because fields in inline fragments should be optional

In @graphql-codegen/client-preset@6.1.2:

This is definitely incorrect because fields in inline fragments should be optional, and they are all gone here

This PR fixes it by correctly applying optionality to fields of a fragment marked with conditional directives when used in a union:

Note: this might be an issue for interfaces as well, but let's solve this one first.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Unit test
• Release alpha and test in codebase

[changeset-bot]

🦋 Changeset detected

Latest commit: 54a4bfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@graphql-codegen/visitor-plugin-common	Patch
@graphql-codegen/typescript-operations	Patch
@graphql-codegen/client-preset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

💻 Website Preview

The latest changes are available as preview in: https://pr-10918.graphql-code-generator.pages.dev