Don't take the address of a subscripted inline-array field#831
Merged
tannergooding merged 1 commit intoJul 19, 2026
Merged
Conversation
The inline-array address-of also fired on a subscripted field lvalue, emitting `&a->Byte[15] = 1` (CS0131). A subscript indexes the inline array in place, so the decay there is an lvalue, not a pointer bind. Skip the address-of when the decayed field is the base of an ArraySubscriptExpr. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #830. That PR added the address-of for an inline-array field decayed to a pointer, but the same logic also fired on a subscripted field lvalue.
IN6_SET_ADDR_LOOPBACKemitted:A subscript indexes the inline array in place, so the decay feeding it is an lvalue, not a pointer bind. Skip the address-of when the decayed field is the base of an
ArraySubscriptExpr(viaIsPrevContextStmt<ArraySubscriptExpr>); the call-argument case still gets&, and compatible mode is unaffected.Verified across all four configs: Default/Latest/Preview keep
&pStruct->Dataon the argument and emit a cleanpStruct->Data[15] = 1; Compatible has no&on either. ExtendedArrayFieldToPointerArgumentTestwith the subscript assignment; full suite green (4205 passed, 0 failed).