Fix ASP connection handler startup race - #2255
Open
suhashollakc wants to merge 1 commit into
Open
Conversation
chkr1011
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2173
Summary
This fixes a startup race in the ASP.NET Core connection handler.
If ASP.NET routes a connection to
MqttConnectionHandler.OnConnectedAsyncbefore the MQTT server adapter has been started,_serverOptionsis still null and the handler throws aNullReferenceException. The connection should be terminated cleanly instead of remaining in an invalid handler state.Changes
Validation
dotnet test --project Source\MQTTnet.Tests\MQTTnet.Tests.csproj --framework net10.0 --no-restore --filter ConnectionHandler_Aborts_Connection_When_Server_Not_Starteddotnet test --project Source\MQTTnet.Tests\MQTTnet.Tests.csproj --framework net10.0 --no-restore --filter FullyQualifiedName~MQTTnet.Tests.ASPdotnet build MQTTnet.slnx --no-restoreNote: the solution build completes successfully with existing benchmark warnings about obsolete ASP.NET hosting APIs.