Embed the solution file in binlog for graph build of a solution#14162
Open
GangWang01 wants to merge 3 commits into
Open
Embed the solution file in binlog for graph build of a solution#14162GangWang01 wants to merge 3 commits into
GangWang01 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit logging for solution files during solution-based graph builds so the .sln can be captured by binlog import embedding (fixing #8170).
Changes:
- Logs a synthetic
ProjectStartedEventArgs/ProjectFinishedEventArgspair for the solution (projectGraph.Solution) during graph build scheduling. - Wraps the graph build execution/reporting logic in a
try/finallyto ensure the solution “finish” event is emitted even on failure. - Tracks overall graph build success to report the solution “succeeded” status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8170
Context
Graph build of a solution does not embed .sln file in binlog
Changes Made
In the scheduler of executing graph build, add ProjectStartedEventArgs with the solution file.
Testing
Notes