Re implement gcperfsim compare#5260
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-implements the gcperfsim compare flow to use the newer GCTraceMetrics/GCTraceMetricComparisonResults model, aligning compare output generation with the analysis pipeline.
Changes:
- Switch
GCPerfSimComparecommand to compute comparisons viaGCTraceMetricComparison.CompareGCPerfsimResultsand emit outputs fromGCTraceMetricComparisonResults. - Update Markdown/JSON presenters to generate compare-command output from
GCTraceMetricComparisonResults(and use regression-oriented deltas). - Add a new
CompareGCPerfsimResults(baselinePath, comparandPath)helper to produceGCTraceMetricComparisonResultcollections from two trace paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/GCPerfSim/GCPerfSimCompare.cs | Rewires the compare command to the new GCTraceMetricComparison + presenter entrypoints. |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Presentation/GCPerfSim/Markdown.cs | Replaces ResultItem-based compare markdown with GCTraceMetricComparisonResults-based output. |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Presentation/GCPerfSim/Json.cs | Replaces legacy categorized JSON generation with serialization of GCTraceMetricComparisonResults. |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Analysis/GCTraceMetricComparison.cs | Adds CompareGCPerfsimResults to build comparison results directly from two trace files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
janvorli
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses GCTraceMetrics class to represent the result of gcperfsim-compare run.