Centralize RuntimeVersions list in DumpTestBase#127102
Draft
Conversation
…gurations and GetDumpSource Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/abad0672-00fa-4cc2-960b-65b41cd0ac62 Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
max-charlamb
April 18, 2026 01:00
View session
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"local"and"net10.0"were duplicated across two methods — once as separateifbranches inTestConfigurationsand once as an inlinenew[] { "local", "net10.0" }inGetDumpSource(). Adding a new runtime version required editing two unrelated code paths.Description
Extracted a single
private static readonly string[] RuntimeVersions = ["local", "net10.0"]field that bothTestConfigurationsandGetDumpSource()now iterate over:TestConfigurations— replaced the pair ofif (!IsVersionSkipped("local"))/if (!IsVersionSkipped("net10.0"))branches with aforeachoverRuntimeVersionsGetDumpSource()— replacednew[] { "local", "net10.0" }withRuntimeVersionsNew runtime versions now require a single-line change in one place.