Implement new --certificate-output argument to save the certificate information#1035
Open
jozefizso wants to merge 2 commits into
Open
Implement new --certificate-output argument to save the certificate information#1035jozefizso wants to merge 2 commits into
--certificate-output argument to save the certificate information#1035jozefizso wants to merge 2 commits into
Conversation
… information The certificate information is useful when signing code with Azure Artifacts Signing which rotates certificates each day. Scripts and automation can use correct certificate used to sign content. This helps with NuGet Gallery where we must manually upload certificates.
jozefizso
marked this pull request as ready for review
July 5, 2026 13:50
dlemstra
reviewed
Jul 5, 2026
| ArtifactSigningServiceProvider trustedSigningServiceProvider = new(); | ||
|
|
||
| return codeCommand.HandleAsync(parseResult, serviceProviderFactory, trustedSigningServiceProvider, filesArgument); | ||
| return codeCommand.HandleAsync(parseResult, serviceProviderFactory, trustedSigningServiceProvider, filesArgument, cancellationToken); |
Collaborator
There was a problem hiding this comment.
I personally think it would make more sense to make it a specific option for this command and execute it after this handle command?
Member
There was a problem hiding this comment.
+1 to this for the ergonomy and usability. Its more straightforward to have a command to retrieve the pubkey, although to be fair there's a small tiny percentage of possibility that the certificate might've rotated when the get is executed after the sign, this way we guarantee we use the same certificate on the operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certificate information is useful when signing code with Azure Artifacts Signing
which rotates certificates each day. Scripts and automation can use correct certificate
used to sign content.
This helps with NuGet Gallery where we must manually upload certificates.