Fix markdown link checker action reference - #5653
Open
mthalman wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
Can we update the policy instead? We should be able to pin it to the sha. /cc @blowdart |
|
Ah the problem is the allow list of actions? That should be updated to limit on versions. So either the allow list needs updating to have the sha, or to just allow umbrelladocs/action-linkspector@*. Obviously being stricter and using the sha in the allow list is safer, however that would mean any time a workflow gets updated with a new version a repo admin will have to update the allow list, which is a huge toil. I'd suggest using the @* approach here as a compromise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Check Markdown Links workflow fails before creating any jobs because it pins
umbrelladocs/action-linkspectorto a commit SHA. The dotnet enterprise Actions policy only permits this action through theumbrelladocs/action-linkspector@v1reference.Solution
Change the action reference to the enterprise-allowed
@v1tag. Add a comment documenting that the tag is intentional and should not be replaced with a SHA unless the enterprise policy changes.