Feature/chimera quotient search - #54
Open
jackraymond wants to merge 17 commits into
Open
Conversation
…s WIP, functional tested in context of the example
…rdinate scheme, without changing behaviour
…y functionally with respect to all three families
Contributor
Author
|
TO DO:
|
jackraymond
commented
Jul 29, 2026
Contributor
Author
There was a problem hiding this comment.
A lot of this file is functionally identical to zephyr_quotient search. Look out for these differences:
- Pegasus and Chimera now supported for quotient search.
- A brand new much find_labeled_subgraph function that is often a better search, and generalizes for many other important lattice classes.
There was a problem hiding this comment.
Thank you for this PR. I had a quick look and I think it adds very useful functionality for Chimera and Pegasus graphs.
Before diving into details, I have a high level question on use case of find_labeled_subgraph.
Is the use case to
- simply speed up Glasgow subgraph finder? Or
- get a deterministic output given the constraints (eg. preserving color classes)? Or
- get an accurate answer to the question of whether
sourceis a subgraph oftarget?
I think this function has room for improvement for (1), (2) (eg. allowing for other color schema on Zephyr), and requires more careful analysis to achieve (3).
If the use case is any of (1) or (2), I think a note in docstring should be added that it doesn't achieve (3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded functionality to support Chimera and Pegasus quotient search alongside Zephyr (already implement).
Some refactorization of functions.
Expansion of the example to plot results, and use quotient search over a defect (rather than fully yielded) lattice.