Fix FTBFS against OpenSSL 4.0 - #6487
Open
amrelsh wants to merge 2 commits into
Open
Conversation
* Include specific asio/ssl headers instead of the asio/ssl.hpp umbrella The umbrella header drags in the deprecated rfc2818_verification (which isn't used) that dereferences the now-opaque types Signed-off-by: Amr Elsheshtawy <amr.elsheshtawy@canonical.com>
* Store X509_get_subject_name result in a const pointer X509_get_subject_name returns a const pointer which should be assigned to const pointer type variables avoiding conversion errors Signed-off-by: Amr Elsheshtawy <amr.elsheshtawy@canonical.com>
amrelsh
force-pushed
the
fix_ftbfs_against_openssl4
branch
from
July 23, 2026 07:58
68243af to
57ec814
Compare
Author
|
@MiguelCompany Hello, whenever you got the time can you take a look at this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<asio/ssl.hpp>pulls in the deprecatedrfc2818_verification, which nolonger compiles on OpenSSL 4.0. so include only the
asio/sslheaders we need.X509_get_subject_name()returns aconstpointer, so store itsresult in a
constpointer to avoid conversion errors.Fixes #6432
@Mergifyio backport 3.3.x