Skip to content

Correct the sign of context effects#616

Merged
strengejacke merged 2 commits intomainfrom
correct_sign
May 5, 2026
Merged

Correct the sign of context effects#616
strengejacke merged 2 commits intomainfrom
correct_sign

Conversation

@strengejacke
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the modelbased package to version 0.14.0.12, primarily changing the contrast calculation logic in get_contexteffects.R from diff(x) to revpairwise and removing the hypothesis column. These changes necessitated updates to the test suite and the 'practical context effect' vignette to account for flipped signs in the results. Feedback focuses on ensuring the sign of the contrast remains consistent with the documented 'Between - Within' definition, as revpairwise may have inverted it. Additionally, several inconsistencies in the vignette's text and statistical values need to be addressed to match the updated calculations.

Comment thread R/get_contexteffects.R
Comment thread vignettes/practical_context_effect.Rmd
Comment thread vignettes/practical_context_effect.Rmd Outdated
@strengejacke strengejacke merged commit 68f8be0 into main May 5, 2026
13 of 20 checks passed
@strengejacke strengejacke deleted the correct_sign branch May 5, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant