refactor: replace detail::Runtime log calls with public API#519
Merged
castler merged 1 commit intoJun 11, 2026
Merged
Conversation
Y-Vaishnavi
force-pushed
the
vy/Add_public_log_recorder_api
branch
5 times, most recently
from
7fa88dc to
ca4b4d2
Compare
- Use score::mw::log::GetDefaultLogRecorder() and GetFallbackLogRecorder() instead of score::mw::log::detail::Runtime directly in TouchStaticDependencies() - Update score_baselibs commit to a0bae98d in MODULE.bazel and examples/MODULE.bazel (includes the public log recorder API added in d12613dd)
Y-Vaishnavi
force-pushed
the
vy/Add_public_log_recorder_api
branch
from
7a24428 to
b0ff1da
Compare
Y-Vaishnavi
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
castler
approved these changes
Jun 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Use score::mw::log::GetDefaultLogRecorder() and
score::mw::log::GetFallbackLogRecorder() instead of accessing score::mw::log::detail::Runtime directly in TouchStaticDependencies().
-update score_baselibs commit to latest main (a0bae98d)