Fix spurious transition completion

[WilliamRoebuck]

A test failure occurred due to a transition reporting a success before its processes had been launched (see log below). This was fixed by moving the lock. New transitions are started depending on the return value of setPendingState, so a lock is needed here to prevent transitions from executing on invalid data.

[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040399 000 ECU1 LM LM log debug verbose 8 Got kRunning for pid 69 ( control_client_mock ) process 0 of group MainPG
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040399 000 ECU1 LM LM log debug verbose 7
[2026-06-08 10:44:33.209] [INFO] [launch_manager] startProcess for MainPG process 0 ( control_client_mock ) done 
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040400 000 ECU1 LM LM log debug verbose 1 Control Client handler nudged 
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040400 000 ECU1 LM LM log debug verbose 3 clock() at successful initial state transition: 21.298000 ms 
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040400 000 ECU1 LM LM log debug verbose 8 ProcessGroupManager::ControlClientHandler: got request kSetStateRequest ( 16 ) re state MainPG/run_target_crash_on_startup_twice of PG MainPG
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040400 000 ECU1 LM LM log debug verbose 6 Pending state for process group MainPG changed from to MainPG/run_target_crash_on_startup_twice 
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040400 000 ECU1 LM LM log debug verbose 1 Request acknowledged.
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040401 000 ECU1 LM LM log debug verbose 9 Graph::setState changes from kInTransition to kSuccess for PG 0 ( MainPG ) 
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040401 000 ECU1 LM LM log info verbose 7 Completed the request for PG MainPG to State MainPG/Startup in 0 ms 
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040401 000 ECU1 LM LM log debug verbose 1 Control Client handler nudged
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040401 000 ECU1 LM LM log debug verbose 1
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040401 000 ECU1 LM LM log debug verbose 6 Pending state for process group MainPG changed from MainPG/run_target_crash_on_startup_twice to
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040402 000 ECU1 LM LM log debug verbose 4 Start transition to MainPG/run_target_crash_on_startup_twice for PG MainPG
[2026-06-08 10:44:33.209] [INFO] [launch_manager] Request acknowledged.
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040402 000 ECU1 LM LM log debug verbose 9
[2026-06-08 10:44:33.209] [INFO] [launch_manager] Graph::setState changes from kSuccess to kInTransition for PG 0 ( MainPG )
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473208 65040403 000 ECU1 LM LM log debug verbose 2 Stop Dependencies: 0
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040403 000 ECU1 LM LM log debug verbose 2 Stop Dependencies: 0
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040403 000 ECU1 LM LM log debug verbose 2
[2026-06-08 10:44:33.209] [INFO] [launch_manager] Stop Dependencies: 0
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040404 000 ECU1 LM LM log debug verbose 2 Stop Dependencies: 0
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040404 000 ECU1 LM LM log debug verbose 2
[2026-06-08 10:44:33.209] [INFO] [launch_manager] Start Dependencies: 0
[2026-06-08 10:44:33.209] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040404 000 ECU1 LM LM log debug verbose 2 Start Dependencies: 0
[2026-06-08 10:44:33.210] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040405 000 ECU1 LM LM log debug verbose 2
[2026-06-08 10:44:33.210] [INFO] [launch_manager] Start Dependencies: 0
[2026-06-08 10:44:33.210] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040405 000 ECU1 LM LM log debug verbose 2 Start Dependencies: 0
[2026-06-08 10:44:33.210] [INFO] [launch_manager] 2026/06/08 10:44:33.5473209 65040406 000 ECU1 LM LM log debug verbose 8
[2026-06-08 10:44:33.210] [INFO] [launch_manager] ProcessGroupManager::ControlClientHandler: Sending kSetStateSuccess ( 20 ) re state MainPG/run_target_crash_on_startup_twice of PG MainPG

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: dda865d4-75f6-41c2-bbdf-e846d26b856b
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (29 packages loaded, 10 targets configured)

Analyzing: target //:license-check (82 packages loaded, 10 targets configured)

Analyzing: target //:license-check (109 packages loaded, 103 targets configured)

Analyzing: target //:license-check (145 packages loaded, 3011 targets configured)

Analyzing: target //:license-check (146 packages loaded, 7610 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8094 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8094 targets configured)

Analyzing: target //:license-check (161 packages loaded, 10106 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 10232 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 21.637s, Critical Path: 2.65s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[github-actions]

The created documentation from the pull request is available at: docu-html