Fixing asan error on mpmc queue#244
Open
MaciejKaszynski wants to merge 1 commit into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
4984b71 to
e4dca9c
Compare
|
The created documentation from the pull request is available at: docu-html |
VukPavicRTRK
suggested changes
Jun 11, 2026
VukPavicRTRK
left a comment
Contributor
There was a problem hiding this comment.
Nice fix for the ASan false positive. One thing to call out: CacheLinePaddedAtomic<T> preserves cache-line size but not cache-line alignment, so it weakens the original false-sharing guarantee provided by alignas(CacheLineSize). At minimum, the comments on m_head, m_tail, and m_stopped should be updated since they're no longer strictly "aligned on their own cache line."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ASAN error with the
MPMCConcurrentQueue#241
Using manual padding instead of
alignasso that ASAN's fake stack can correctly.Setting the alignment on the class itself didn't fix the asan error as it would just set the alignment for the class itself.