Lifecycle Feature Integration Tests by Saumya-R · Pull Request #238 · eclipse-score/reference_integration

Saumya-R · 2026-05-21T17:54:21Z

This PR introduces a comprehensive test suite for S-CORE lifecycle management framework integration, validating that applications can properly integrate with lifecycle services.

Coverage

92% requirement coverage: 85 of 92 lifecycle requirements validated
Dual language support: All tests implemented in both Rust and C++
10 major capability areas: Process launching, dependency management, conditional launching, run targets, termination, monitoring & recovery, control interface, configuration, logging, and debug support

Key Features

Validated Capabilities:

Process Launching (24/24 requirements) — execution state reporting, arguments, security, resources, I/O
Conditional Launching (15/15) — path, environment, and process state conditions
Monitoring & Recovery (16/16) — watchdog, health monitoring, failure recovery
Process Termination (9/9) — graceful shutdown, signal handling, timeout configuration
Configuration Management (8/8) — modular config, OCI v1.2.0 compliance, validation
Run Targets (4/4) — runtime state management and transitions
Control Interface (4/4) — custom conditions and control commands
Logging (5/5) — state transitions, timestamps, DAG visualization

Technical Approach

Real API Integration: Uses actual lifecycle and health monitoring APIs from @score_lifecycle_health
Three-layer architecture: Python test orchestration + Rust/C++ scenario implementations
Graceful degradation: Tests run successfully without Launch Manager daemon present
Language-appropriate patterns: Structured JSON logging (Rust) vs. plain text (C++)

Lifecycle Integration Test Coverage

Click to expand full coverage table

Test File	Key Test Functions	Requirements Covered
test_control_interface_support.py	`test_custom_condition_signaled`, `test_control_interface_integration`	`custom_cond_support`
test_process_arguments.py	`test_process_args_received`, `test_working_directory_set`	`process_launch_args`, `cwd_support`, `process_input_output`
test_process_security.py	`test_uid_gid_configured`, `test_security_policy`, `test_supplementary_groups`	`uid_gid_support`, `capability_support`, `support_secpol_type`, `secpol_non_root`, `supplementary_groups`
test_process_resources.py	`test_priority_configured`, `test_scheduling_policy`, `test_cpu_affinity`, `test_resource_limits`	`launch_priority_support`, `scheduling_policy`, `runmask_support`, `process_rlimit_support`, `aslr_support`
test_conditional_launching.py	`test_condition_timeout_configured`, `test_process_condition_check`, `test_dependency_check`, `test_path_condition_check`, `test_env_condition_check`, `test_polling_interval_configured`	`waitfor_support`, `cond_process_start`, `total_wait_time_support`, `polling_interval`, `validate_conditions`, `validation_conditions`, `launcher_status_storage`, `condition_check_method`, `config_actions_cond`, `path_condition_check`, `env_variable_cond_check`, `dependency_check`, `check_dependency_exec`, `define_swc_dependencies`, `stop_sequence`
test_process_management.py	`test_process_adoption`, `test_multiple_instances`, `test_dependency_validation`, `test_stop_order`	`running_processes`, `drop_supervsion`, `multi_start_support`, `consistent_dependencies`, `stop_process_dependents`, `stop_order_spec`, `oci_compliant`
test_run_targets.py	`test_run_target_defined`, `test_run_target_started`, `test_run_target_switch`, `test_process_state_communication`	`run_target_support`, `start_named_run_target`, `switch_run_targets`, `process_state_comm`
test_process_termination.py	`test_graceful_shutdown`, `test_fast_shutdown`, `test_dependency_order_termination`, `test_signal_delay_configured`, `test_stop_timeout_configured`	`configurable_timeout`, `process_termination`, `terminationn_dependency`, `time_to_wait_config`, `launch_manager_shutdown`, `slow_shutdown_support`, `fast_shutdown_support`, `launcher_exit_shutdown`, `shutdown_signal`
test_monitoring_and_recovery.py	`test_failure_detection`, `test_process_monitoring`, `test_liveliness_detection`, `test_recovery_action_configured`, `test_watchdog_configured`, `test_external_notification`, `test_self_health_check`	`monitor_abnormal_term`, `ext_monitor_notify`, `recovery_action_support`, `recov_run_target_switch`, `smart_watchdog_config`, `configurable_wait_time`, `monitoring_processes`, `failure_detect`, `liveliness_detection`, `process_monitoring`, `process_failure_react`, `multi_instance_support`, `lm_self_health_check`, `lm_ext_watchdog_notify`, `lm_ext_wdg_failed_test`, `lm_ext_watchdog_cfg`
test_control_commands.py	`test_control_commands_available`, `test_query_commands_available`, `test_status_reporting`, `test_run_target_activation`	`control_commands`, `query_commands`, `controlif_status`, `request_run_target_start`
test_logging.py	`test_process_launch_logged`, `test_state_transitions_logged`, `test_timestamp_present`, `test_dag_logging`	`slog2_logging`, `process_logging_support`, `log_timestamp`, `dag_logging_controlif`, `dependency_visu`
test_configuration_management.py	`test_modular_config_support`, `test_oci_compatibility`, `test_session_extension`, `test_module_clustering`, `test_default_properties`, `test_lazy_executable_check`, `test_config_validation`	`modular_config_support`, `runtime_config_compat`, `session_extension`, `clustering_modules_supp`, `central_default_defines`, `lazy_check`, `deps_visualization`, `offline_config_valid`
test_debug_and_terminal.py	`test_debug_mode_enabled`, `test_debugger_wait_state`, `test_terminal_session_leader`	`debug_support`, `support_held_state`, `terminal_support`
test_io_and_file_descriptors.py	`test_stdout_redirection`, `test_stderr_redirection`, `test_fd_inheritance_control`, `test_process_detachment`, `test_retry_configuration`	`std_handle_redir`, `fd_inheritance`, `detach_parent_process`, `retries_configurable`

File	Change	Requirements / Review Items Covered	Notes
README.md	Expanded docs	Add lifecycle summary + pytest build instructions to README	Includes Bazel daemon commands, lifecycle filters, pytest direct runs, and scenario prebuild guidance
LIFECYCLE_TESTS_SUMMARY.md	Updated docs	Document pytest build/run flow and daemon notes	Serves as detailed lifecycle mapping/reference
conftest.py	Test infra improvement	Fix build-scenarios failures; align Bazel config usage	Added --bazel-config and FIT_BAZEL_CONFIG support; build helper uses explicit --config
daemon_helpers.py	Fixture/runtime fix	Replace daemon-skip behavior with runnable setup	Builds/copies flatbuffer configs and required daemon binaries into etc/
BUILD	Build target addition	Support daemon flatbuffer config generation	Added daemon_lifecycle_configs target
daemon_launch_manager_config.json	New config	Provide daemon-specific launch manager source config	Used to generate runtime flatbuffer artifacts
BUILD	New BUILD file	Export daemon config for Bazel consumption	Enables config target wiring
test_process_launching_with_daemon.py	Test logic update	“Skip” review comment resolved for recovery/watchdog	Tests now assert observed behavior/log diagnostics instead of unconditional skip
test_dependency_ordering.py	Assertion alignment	Identical wording requirement	Assertions updated to canonical lifecycle wording
test_run_targets.py	Assertion robustness	Handle dynamic message behavior	Prevents false negatives from acceptable output variants
launch_manager_support.cpp	Scenario output standardization	Identical wording emitted across implementations	C++ wording aligned to Rust canonical lifecycle text
pyproject.toml	Config fix	Resolve pytest mark/config handling issue	Correct pytest section header so markers/options load properly

github-actions · 2026-05-21T18:21:28Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new “lifecycle” feature integration test suite (Rust + C++) and a corresponding Python test layer to validate lifecycle/Launch Manager requirement coverage.

Changes:

Register a new lifecycle scenario group for both Rust and C++ scenario runners.
Add lifecycle scenario implementations (Rust uses lifecycle + health monitoring libs; C++ provides mostly stdout-based demonstrations).
Add Python pytest test cases + shared LifecycleScenario base class; include new lifecycle documentation.

Reviewed changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
feature_integration_tests/test_scenarios/rust/src/scenarios/mod.rs	Registers lifecycle scenario group under root.
feature_integration_tests/test_scenarios/rust/src/scenarios/lifecycle/mod.rs	Adds lifecycle scenario group wiring for Rust.
feature_integration_tests/test_scenarios/rust/src/scenarios/lifecycle/launch_manager_support.rs	Implements Rust lifecycle scenarios (health monitoring + lifecycle client).
feature_integration_tests/test_scenarios/rust/BUILD	Adds Rust deps for lifecycle/health monitoring libraries.
feature_integration_tests/test_scenarios/cpp/src/scenarios/mod.cpp	Registers lifecycle scenario group under root (C++).
feature_integration_tests/test_scenarios/cpp/src/scenarios/lifecycle/launch_manager_support.h	Declares lifecycle scenario factory functions (C++).
feature_integration_tests/test_scenarios/cpp/src/scenarios/lifecycle/launch_manager_support.cpp	Implements lifecycle scenarios (primarily stdout demonstrations; one lifecycle client call).
feature_integration_tests/test_scenarios/cpp/BUILD	Adds C++ lifecycle client dependency.
feature_integration_tests/test_cases/tests/lifecycle/test_run_targets.py	Adds pytest validations for run-target behavior/log output.
feature_integration_tests/test_cases/tests/lifecycle/test_process_termination.py	Adds pytest validations for termination behavior/log output.
feature_integration_tests/test_cases/tests/lifecycle/test_process_security.py	Adds pytest validations for security-related output.
feature_integration_tests/test_cases/tests/lifecycle/test_process_resources.py	Adds pytest validations for resource-management output.
feature_integration_tests/test_cases/tests/lifecycle/test_process_management.py	Adds pytest validations for process-management output.
feature_integration_tests/test_cases/tests/lifecycle/test_process_launching.py	Adds pytest validations for lifecycle client integration output.
feature_integration_tests/test_cases/tests/lifecycle/test_process_arguments.py	Adds pytest validations for argument/cwd output.
feature_integration_tests/test_cases/tests/lifecycle/test_parallel_launching.py	Adds pytest validations for parallel-monitor output.
feature_integration_tests/test_cases/tests/lifecycle/test_monitoring_and_recovery.py	Adds pytest validations for monitoring/recovery output.
feature_integration_tests/test_cases/tests/lifecycle/test_logging.py	Adds pytest validations for logging-support output.
feature_integration_tests/test_cases/tests/lifecycle/test_io_and_file_descriptors.py	Adds pytest validations for I/O + FD management output.
feature_integration_tests/test_cases/tests/lifecycle/test_dependency_ordering.py	Adds pytest validations for sequential checkpoint output.
feature_integration_tests/test_cases/tests/lifecycle/test_debug_and_terminal.py	Adds pytest validations for debug/terminal output.
feature_integration_tests/test_cases/tests/lifecycle/test_control_interface_support.py	Adds pytest validations for custom-condition output.
feature_integration_tests/test_cases/tests/lifecycle/test_control_commands.py	Adds pytest validations for control/query command output.
feature_integration_tests/test_cases/tests/lifecycle/test_configuration_management.py	Adds pytest validations for configuration-management output.
feature_integration_tests/test_cases/lifecycle_scenario.py	Introduces shared base class + helpers for lifecycle FITs.
feature_integration_tests/test_cases/BUILD	Adds new lifecycle scenario module to Bazel test data.
feature_integration_tests/README_FIT_LIFECYCLE.md	Adds detailed lifecycle FIT documentation.
feature_integration_tests/LIFECYCLE_TESTS_SUMMARY.md	Adds summary of lifecycle FIT coverage and inventory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 8 comments.

Copilot

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated 10 comments.

FScholPer · 2026-06-25T07:15:52Z

@Saumya-R can you please rebase

Saumya-R · 2026-06-30T05:46:30Z

@FScholPer The branch is rebased.

) * ci: enable cr_checker copyright check via pre-commit hook * fix: add copyright headers to files missing SPDX block * fix: add missing copyright header to overall_status.rst * fix: remove broken copyright_checker Bazel target * fix: add missing blank line after copyright block in overall_status.rst doc: remove scrample references from ebclfsa documentation + update devcontainer (eclipse-score#269) * chore: Bump devcontainer to v.1.7.0 * doc: remove scrample references in the EB clfsa documentation The scrample code had been removed already but this document was forgotten. upload sarif results to security tab (eclipse-score#260) Co-authored-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com> Integrate Time module (eclipse-score#273) * Integrate Time module * Deploy time examples * Make sure qemu has enought permisisons * Make exmplaes stop after time Bump `score_bazel_cpp_toolchains` to the latest version (eclipse-score#274) The latest version of toolchain provides support for coverage for QNX builds. Signed-off-by: Nikola Radakovic <nikola.ra.radakovic@bmw.de> Add QNX8 aarch64 build support (eclipse-score#241) * Add QNX8 aarch64 build support * review findings * free more space adding launch manager fit test cases adding feature integration test cases for other requirements removing hard fail conditions updated documents adding copilot reivew fixes Fixed restart behavior on the same instance, Hardened shutdown race handling updated the statement clearing self.process after shutdown fixed pytest build environment issues fixxing the python build issues copyright fixes

PiotrKorkus · 2026-07-06T15:15:36Z

+    }
+};
+
+std::vector<std::string> parse_string_array_field(const std::string& input, const std::string& field_name) {


L3 — MED/LOW: parse_string_array_field regex JSON parsing is unsound. (a) Not scoped to the test object — regex_search runs over the whole document and returns the first same-named array anywhere (e.g. one in defaults shadows test.args). (b) \[(.*?)\] truncates at the first ], breaking nested arrays and any ] inside a string value. (c) the value regex \"([^\"]*)\" treats an escaped \" as a terminator, yielding garbage tokens. Use the JSON parser already used elsewhere in this file and navigate root -> test -> field.

PiotrKorkus · 2026-07-06T15:15:36Z

+            self.process = None
+            raise RuntimeError(f"Launch Manager daemon failed to start. Exit code: {return_code}\nLogs:\n{log_content}")
+
+    def stop(self, shutdown_timeout: float = 5.0) -> None:


L4 — MED/LOW: daemon child processes leaked; logs truncated on restart. stop() signals only the daemon, not its process group (no start_new_session/os.killpg), so supervised children are orphaned on daemon crash/start failure and pollute later pgrep -f runs. Separately, open(self.log_file, "w") (line 258) truncates on every start(), discarding pre-restart supervision logs before test_supervised_app_launches asserts on them.

PiotrKorkus · 2026-07-06T15:15:36Z

+            )
+
+            if result.returncode == 0:
+                pid = result.stdout.strip().split("\n")[0]


L5 — MED/LOW: pgrep -f <app_name> first-PID match is fragile. -f matches the full command line and only the first match is taken (lines 205, 221), so a leaked process from a prior run, a bazel invocation, or the pytest cmdline referencing the app name can be selected — making assert new_pid != pid meaningless. Match the exact binary and handle multiple PIDs.

PiotrKorkus · 2026-07-06T15:15:37Z

+            else:
+                logs = daemon.get_logs()
+                recovery_signals = [
+                    f"unexpected termination of process",


L6 — LOW: dead f-string prefixes. f"unexpected termination of process" (line 233) and f"Got kRunning timeout for process" (line 236) have no interpolation — drop the f. Harmless, but flags copy-paste.

PiotrKorkus · 2026-07-06T15:15:37Z

+            },
+            "run_target": {
+                "transition_timeout": 10,
+                "recovery_action": {"switch_run_target": {"run_target": "fallback"}},


L7 — MED/LOW: create_daemon_integrated_config fallback target name mismatch (dead code). Uses switch_run_target -> "fallback" while the shipped schema uses the top-level fallback_run_target (configs/daemon_launch_manager_config.json:103). Recovery may not resolve to the intended fallback if this helper is ever used.

…from test config

…m the config

…s are missing

…ow mean the same thing

Saumya-R requested a review from Copilot May 22, 2026 10:08

Copilot AI reviewed May 22, 2026

View reviewed changes

Saumya-R requested a review from Copilot May 22, 2026 12:03

Copilot AI reviewed May 22, 2026

View reviewed changes

Saumya-R force-pushed the saumya_lifecycle_fit branch 2 times, most recently from 335aff1 to e4a0697 Compare May 22, 2026 12:30

Saumya-R requested a review from Copilot May 22, 2026 12:34

Copilot AI reviewed May 22, 2026

View reviewed changes

Saumya-R force-pushed the saumya_lifecycle_fit branch from 424c6c2 to 2dd9ed2 Compare June 1, 2026 17:29

Saumya-R marked this pull request as ready for review June 1, 2026 17:32

Saumya-R requested review from AlexanderLanin, FScholPer, MaximilianSoerenPollak, PiotrKorkus, antonkri, dcalavrezo-qorix, lurtz, nradakovic, opajonk and pawelrutkaq as code owners June 1, 2026 17:32

Saumya-R changed the title ~~adding launch manager fit test cases~~ Lifecycle Feature Integration Tests Jun 2, 2026

Saumya-R requested a review from Copilot June 2, 2026 05:15

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Saumya-R requested a review from Copilot June 3, 2026 09:29

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Saumya-R force-pushed the saumya_lifecycle_fit branch 2 times, most recently from 1305799 to 0b45ed8 Compare June 9, 2026 06:15

FScholPer previously approved these changes Jun 25, 2026

View reviewed changes

Saumya-R force-pushed the saumya_lifecycle_fit branch from 0b45ed8 to 6157870 Compare June 30, 2026 05:01

Saumya-R dismissed FScholPer’s stale review via 863dea8 June 30, 2026 05:42

Saumya-R force-pushed the saumya_lifecycle_fit branch from 863dea8 to ad8d0d7 Compare June 30, 2026 05:43

Saumya-R requested a review from FScholPer June 30, 2026 05:57

Saumya-R force-pushed the saumya_lifecycle_fit branch 3 times, most recently from f8f0489 to ba1be07 Compare July 1, 2026 12:29

Saumya-R force-pushed the saumya_lifecycle_fit branch from ba1be07 to 160f9c6 Compare July 1, 2026 12:34

FScholPer previously approved these changes Jul 3, 2026

View reviewed changes

Saumya-R mentioned this pull request Jul 6, 2026

FIT lifecycle #227

Open

PiotrKorkus requested changes Jul 6, 2026

View reviewed changes

Comment thread feature_integration_tests/test_cases/BUILD Outdated

added fit_daemon running on CICD

e716941

Saumya-R dismissed FScholPer’s stale review via e716941 July 6, 2026 12:19

PiotrKorkus reviewed Jul 6, 2026

View reviewed changes

Comment thread .github/workflows/test_and_docs.yml

PiotrKorkus requested changes Jul 6, 2026

View reviewed changes

adding test_daemon in cicd

ec0b6ec

Saumya-R marked this pull request as draft July 8, 2026 09:00

Saumya-R added 8 commits July 8, 2026 14:57

removed the additional change in the test_and_docs.yml

cbaf9cf

Removed the JSON-config mutation flow that the daemon does not consume

8ab656c

Changed hardcoded defaults to intentionally wrong values that differ …

a18f8e3

…from test config

The C++ scenario now properly reads supplementary groups

a97f4e2

The C++ ProcessResources scenario now properly reads CPU affinity fro…

1cb959d

…m the config

C++ now throws a clearer, stable message in ProcessArguments when arg…

67195ff

…s are missing

aligned both implementations and the test semantics so Rust and C++ n…

7a97c79

…ow mean the same thing

fixed review comments H7-H12

dab99f5

Uh oh!

Conversation

Saumya-R commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage

Key Features

Validated Capabilities:

Technical Approach

Lifecycle Integration Test Coverage

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FScholPer commented Jun 25, 2026

Uh oh!

Saumya-R commented Jun 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrKorkus Jul 6, 2026

Saumya-R commented May 21, 2026 •

edited

Loading