feat: jana2 +perfetto#303
Draft
wdconinc wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Spack environment configuration to build jana2 with Perfetto support enabled, and bumps the pinned eic/eic-spack revision accordingly so the build uses the matching Spack package definitions.
Changes:
- Enable the
+perfettovariant forjana2@2026.02.00inspack-environment/packages.yaml. - Update
EICSPACK_VERSIONineic-spack.shto a newer pinned revision.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spack-environment/packages.yaml |
Turns on +perfetto for the jana2 Spack spec so images include the profiling plugin. |
eic-spack.sh |
Advances the pinned eic/eic-spack revision used by CI/builds, presumably to pick up the jana2+perfetto packaging support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR adds the perfetto plugin to jana2, for tracking and profiling.
Needs:
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply