Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Spack environment defaults to enable the DD4hep G4HepEm plugin path and to use an npsim revision that defaults to G4HepEm, aligning the container images with the intended simulation backend.
Changes:
- Enable the
g4hepemvariant foractsinspack-environment/packages.yaml. - Switch
npsimfrom a released version pin (@1.6.0) to a git-based version (@git.g4hepem). - Update the pinned
eic/eic-spackcommit used during container builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spack-environment/packages.yaml | Enables +g4hepem for ACTS and changes the default npsim version to a git ref to pick up G4HepEm-default behavior. |
| eic-spack.sh | Bumps the pinned eic/eic-spack commit to pick up required Spack package recipe changes. |
| npsim: | ||
| require: | ||
| - '@1.6.0' | ||
| - '@git.g4hepem' |
Contributor
Author
There was a problem hiding this comment.
Acknowledged. This is for testing only, until the named ref is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR enables the G4HepEm plugin in DD4hep, and uses it in npsim by default.
Needs:
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
EM shower physics will defer to G4HepEm.