feat: add calibrated scalar maps with Plot2D - #242
Merged
Conversation
|
bobleesj
marked this pull request as ready for review
September 8, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New public widgets and shared-helper refactors need an issue or maintainer
discussion first. Bug fixes and features that stay inside one existing widget
can open a pull request directly. See
pull request classes.
What problem does it solve?
Adds Plot2D for existing scalar maps with physical axes and a labeled color
scale, without conflating them with spatial Show2D images. Public API:
quantem.widget.Plot2D(data, *, x, y, ...),set_data(data)andfigure(); data are not scientifically transformed.What should reviewer(s) do?
After the required maintainer discussion, review calibrated row/column behavior
and the default static-preview / opt-in full-state policy. Drive P2D-01 through
P2D-08, including actual notebook-manager payload and save/reopen behavior,
before approving. This proposal has no standalone HTML export.
Verification
PR-hygiene/workflow assertion failed. The 118 Plot2D/shared saved-state tests pass.
or baked state. Independent review includes TkAgg and calibrated preview checks.
display/backends/webgpu/colormaps, which the shared sync manifest omits.CI failure.
preview freshness, latency, and public GPU dependency availability. Tests use
an explicitly pinned compatible GPU wheel; PyPI cannot resolve required rc6.
This PR follows the
scikit-package workflow for
reproducible scientific software.