feat: resize standalone Show1D plots in both dimensions - #243
Merged
bobleesj merged 1 commit intoSep 8, 2026
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does it solve?
A standalone Show1D plot could change height through its corner handle, but
not width. Add explicit initial/maximum widths and diagonal resizing while
preserving the existing side-panel resize behavior. Pointer-move previews stay
browser-local and animation-frame throttled; dimensions synchronize on release.
What should reviewer(s) do?
Create a standalone Show1D with
max_width=900, drag the lower-right cornerdiagonally, and use Reset View. Check that export retains the dimensions.
For a plot with a side panel, check that horizontal dragging still reallocates
space between the plot and panel rather than resizing the whole viewer.
Verification
900x292.5 to 740x332.5 CSS pixels through its corner handle.
Failures concern relocated GPU source-contract paths, an outdated workflow
test, and a folder-watcher timing assertion; this PR does not change them.
This PR follows the
scikit-package workflow for
reproducible scientific software.