Skip to content

feat: resize standalone Show1D plots in both dimensions - #243

Merged
bobleesj merged 1 commit into
electronmicroscopy:mainfrom
bobleesj:sep-8-show1d-diagonal-resize
Sep 8, 2026
Merged

feat: resize standalone Show1D plots in both dimensions#243
bobleesj merged 1 commit into
electronmicroscopy:mainfrom
bobleesj:sep-8-show1d-diagonal-resize

Conversation

@bobleesj

@bobleesj bobleesj commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

What problem does it solve?

A standalone Show1D plot could change height through its corner handle, but
not width. Add explicit initial/maximum widths and diagonal resizing while
preserving the existing side-panel resize behavior. Pointer-move previews stay
browser-local and animation-frame throttled; dimensions synchronize on release.

What should reviewer(s) do?

Create a standalone Show1D with max_width=900, drag the lower-right corner
diagonally, and use Reset View. Check that export retains the dimensions.
For a plot with a side panel, check that horizontal dragging still reallocates
space between the plot and panel rather than resizing the whole viewer.

Verification

  • Focused Plot2D/Show1D Python suite: 41 passed.
  • Frontend build: all 11 bundles; typecheck passed; 180 frontend tests passed.
  • Installed-wheel Jupyter/Chrome check: standalone plot changed from
    900x292.5 to 740x332.5 CSS pixels through its corner handle.
  • Wider Python suite was also run: 1168 passed, 29 skipped, 11 failed.
    Failures concern relocated GPU source-contract paths, an outdated workflow
    test, and a folder-watcher timing assertion; this PR does not change them.
  • No scientific arrays or numerical computation are changed.

This PR follows the
scikit-package workflow for
reproducible scientific software.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
  • Delete bobleesj/quantem.widget:sep-8-show1d-diagonal-resize from its remote if you own it, it is not long-lived, and no other PR uses it.
  • Remove the dedicated worktree and local sep-8-show1d-diagonal-resize branch after confirming the worktree is clean.
  • Fetch electronmicroscopy/quantem.widget and update local main before starting new work.

@bobleesj
bobleesj merged commit 9d8d76d into electronmicroscopy:main Sep 8, 2026
4 checks passed
@bobleesj
bobleesj deleted the sep-8-show1d-diagonal-resize branch September 8, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant