flags unknown config keys and fixes a bug with env prefixes - #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this PR addresses:
Fixed a few bugs in config which were revealed as we are working on the
emdatabaseconfig.check_key_valwarns on a top-level key in neither the registered defaults nor deprecations, and still sets it. Nested keys under a known key are not checked.There is also a related quantem-tutorials PR for config.ipynb: electronmicroscopy/quantem-tutorials#14
What should the reviewer(s) do:
This shouldn't really affect anyone, so hopefully just make sure it didn't introduce any other bugs.
Use the following checklist items when applicable (select only what applies):