Annotate activation functions with Nx blocks - #636
Closed
seanmor5 wants to merge 2 commits into
Closed
Conversation
polvalente
reviewed
May 26, 2026
|
|
||
| """ | ||
| defn softplus(x) do | ||
| defblock Axon.Block, softplus(x) do |
Member
There was a problem hiding this comment.
@josevalim @seanmor5 wdyt about having a single Axon.Block struct with module, function and arity as the name?
%Axon.Block{module: Axon.Activations, function: :softplus, arity: 1, options: ...}
%Axon.Block{module: Axon.Layers, function: :dense, arity: 2, options: ...}or something like that
Member
There was a problem hiding this comment.
Actually, I think we should have it like this:
defblock selu -> Axon.Activations.Selu
defblock SeLU, selu -> Axon.Activations.SeLU
Where the block name is given by a module suffix optionally. This makes it easier to define, avoids accidental name collisions and the optional name argument gives flexibility for non-standard casing.
Member
|
closed in favor of #639 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to the introduction of
Nx.blockand custom calls. To make this transition easier, I added adefblockconstruct which marks a function as anNx.blockwith a generated camel-case module name equivalent to the function name.The plan would be to use this for all layers as well, but that requires some changes because some layers are
deftransforminstead ofdefn.Axon blocks will be prefixed with
Axon.Block. It's confusing a bit because these are different thanAxon.block