Presets: Include Colors & Active Status#2580
Merged
Merged
Conversation
* Add colors and active state to presets including changing data models. * Introduce new version from presets with support for colors and state. * Convert V1 to V2 while import using default colors
Those modules where too large to be in one file. Changes included splitting them into multiple files. No code changes included.
* Apply Colors and active state from presets when applied to a sessions making sure we are not invoking search queries in back end on disabled search entries.
Importing presets from legacy Chipmunk 3 will include colors and active state in legacy import
Display both colors and active/inactive state for filters and search values in presets UI both as read-only with adding a way to activate/deactivate presets in edit mode
Split notification file into two modules separating banner from the normal notification rendering. Notifications banner used to have one ID which will be persisted to over multiple notifications making the notification sharing the max height making new notifications take much more height than needed if we have a large notification previously.
Improve message for import/export notifications + Fix clippy warnings
AmmarAbouZor
force-pushed
the
color-active-presets
branch
from
0768929 to
3ce1f40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2573
It includes colors and active/inactive status in presets: